From: Richard M. Stallman <rms@gnu.org>
Date: Thu, 13 May 1993 03:23:40 +0000 (+0000)
Subject: Don't put frame-initialize and frame-notice-user-settings on hooks.
X-Git-Tag: archive/raspbian/1%29.2+1-2+rpi1^2~5^2~96297
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=fc4d4afb41a8d1f2daac309ffd1d313352e405ec;p=emacs.git

Don't put frame-initialize and frame-notice-user-settings on hooks.
They are now called directly.
---

diff --git a/lisp/frame.el b/lisp/frame.el
index 488fd682cc0..fd828b47786 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -72,8 +72,11 @@ These supercede the values given in `default-frame-alist'.")
 ;;; 3) Once the init file is done, we apply any newly set parameters
 ;;; in initial-frame-alist to the frame.
 
-(add-hook 'before-init-hook 'frame-initialize)
-(add-hook 'window-setup-hook 'frame-notice-user-settings)
+;; These are now called explicitly at the proper times, 
+;; since that is easier to understand.
+;; Actually using hooks within Emacs is bad for future maintenance. --rms.
+;; (add-hook 'before-init-hook 'frame-initialize)
+;; (add-hook 'window-setup-hook 'frame-notice-user-settings)
 
 ;;; If we create the initial frame, this is it.
 (defvar frame-initial-frame nil)